Expose `default_color_mode` in rx.Config by masenf · Pull Request #6716 · reflex-dev/reflex

masenf · 2026-07-07T22:29:57Z

No description provided.

greptile-apps · 2026-07-07T22:32:55Z

Greptile Summary

This PR exposes default_color_mode in rx.Config (accepting "system", "light", or "dark", also settable via REFLEX_DEFAULT_COLOR_MODE), allowing apps to control the initial color mode without requiring Radix themes. The value is validated at config init time and threaded into both the compiled JS context and the pre-hydration preload script.

Config field + validation: default_color_mode: LiteralColorMode = "system" added to BaseConfig; Config.__init__ validates it after env-var resolution using LiteralColorMode.__args__.
Color mode constants refactored: SYSTEM_COLOR_MODE, LIGHT_COLOR_MODE, DARK_COLOR_MODE, and LiteralColorMode moved from style.py into reflex_base.constants.base and re-exported from style.py to preserve the public API.
JS context/provider refactored: ColorModeContext.Provider (with toggleColorMode/setColorMode) moved from RadixThemesColorModeProvider into the always-present ThemeProvider, so color-mode context is available without Radix; the preload script now uses the resolved default_color_mode as its localStorage fallback to prevent flash of wrong theme.

Confidence Score: 5/5

The change is well-scoped — a new config field with validation, a constants refactor, and a JS provider restructuring, all covered by targeted tests.

Config validation runs after env-var resolution so invalid values (including those from REFLEX_DEFAULT_COLOR_MODE) are caught early. The JS refactoring correctly moves context provision to ThemeProvider and the preload script default is consistent with the compiled context value. Tests cover all three valid modes, the precedence logic, env-var override, and document-root compilation.

No files require special attention.

Important Files Changed

Filename	Overview
packages/reflex-base/src/reflex_base/config.py	Adds `default_color_mode: LiteralColorMode = "system"` field to `BaseConfig` and validates it in `Config.__init__` against `constants.LiteralColorMode.__args__` after env-var resolution.
packages/reflex-base/src/reflex_base/constants/base.py	Extracts `SYSTEM_COLOR_MODE`, `LIGHT_COLOR_MODE`, `DARK_COLOR_MODE` string constants and `LiteralColorMode` type alias from `style.py` into the shared constants module.
reflex/compiler/compiler.py	Adds `_resolve_default_color_mode` helper that chooses between an explicit `rx.theme(appearance=...)` and `Config.default_color_mode`; threads the resolved value into both `compile_contexts` and `compile_document_root`.
reflex/utils/misc.py	Converts `preload_color_theme` to accept a `default_color_mode` argument, injecting it into the inline script via an f-string so the pre-hydration fallback matches the compiled context.
packages/reflex-base/src/reflex_base/.templates/web/utils/react-theme.js	Moves `ColorModeContext.Provider` (with `toggleColorMode` / `setColorMode`) from `RadixThemesColorModeProvider` into `ThemeProvider`, so color-mode context is available without Radix.
packages/reflex-base/src/reflex_base/.templates/web/components/reflex/radix_themes_color_mode_provider.js	Stripped down to a thin Radix-specific CSS effect; context providing is now handled by `ThemeProvider`.
reflex/compiler/utils.py	Passes `default_color_mode` through to `preload_color_theme` when creating the document root.
tests/units/compiler/test_compiler.py	Adds comprehensive parametrized tests for `_resolve_default_color_mode`, `compile_contexts`, `preload_color_theme`, and `compile_document_root`; uses an isolated config mock to avoid singleton leakage.
tests/units/test_config.py	Adds tests for the `default_color_mode` default value and env-var override via `REFLEX_DEFAULT_COLOR_MODE`.
packages/reflex-base/src/reflex_base/style.py	Removes locally-defined color mode constants/type and re-imports them from `reflex_base.constants.base` (re-exporting with `as` aliases to preserve public API).

_{Reviews (8): Last reviewed commit: "validate Config.default_color_mode" | Re-trigger Greptile}

codspeed-hq · 2026-07-07T22:33:05Z

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 8 skipped benchmarks¹

_{Comparing masenf/default-color-mode (0f55fea) with main (9a5c4d3)}

8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f5a912f962

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…mode

Decouple the actual toggle / set color mode functionality from radix so it can be used without including the RadixThemesColorModeProvider. Simplify RadixThemesColorModeProvider to only be responsible for flipping the .radix-themes root classes.

use setColorMode instead of setTheme for improved validation

Expose default_color_mode in rx.Config

f5a912f

masenf requested a review from a team as a code owner July 7, 2026 22:29

greptile-apps Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread tests/units/compiler/test_compiler.py Outdated

chatgpt-codex-connector Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread reflex/compiler/compiler.py Outdated

masenf added 8 commits July 7, 2026 15:41

better mocking of Config is color mode tests

0b76e74

preload_color_mode script uses the configured default_color_mode

9b98b43

add news fragment

3709c9b

Merge remote-tracking branch 'origin/main' into masenf/default-color-…

e5a2352

…mode

if the compiled default color mode changes in dev mode, set it

e69d0d7

use setColorMode instead of setTheme for improved validation

set the theme in localstorage too

51bd8bb

validate Config.default_color_mode

0f55fea

FarhanAliRaza approved these changes Jul 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Expose `default_color_mode` in rx.Config#6716

Expose `default_color_mode` in rx.Config#6716
masenf wants to merge 9 commits into
mainfrom
masenf/default-color-mode

masenf commented Jul 7, 2026

Uh oh!

greptile-apps Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jul 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

masenf commented Jul 7, 2026

Uh oh!

greptile-apps Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

codspeed-hq Bot commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Jul 7, 2026 •

edited

Loading

codspeed-hq Bot commented Jul 7, 2026 •

edited

Loading